Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate a lot of patterns #733

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Deprecate a lot of patterns #733

merged 2 commits into from
Jan 23, 2025

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jan 22, 2025

Changelog

- description: |
    Deprecate patterns, to lower entry bar knowledge to this codebase
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/deprecate-more-patterns branch 3 times, most recently from 33dc07b to e5b7eff Compare January 22, 2025 16:45
@smelc smelc force-pushed the smelc/deprecate-more-patterns branch from e5b7eff to a0bf51f Compare January 23, 2025 10:31
@smelc smelc changed the title Deprecate all patterns that were not abbreviating a complex expression (that's nearly all of them) Deprecate a lot of patterns Jan 23, 2025
@smelc smelc marked this pull request as ready for review January 23, 2025 10:38
@smelc smelc merged commit acc6d1f into master Jan 23, 2025
30 of 33 checks passed
@smelc smelc deleted the smelc/deprecate-more-patterns branch January 23, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants