Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Our codebase is hard to enter. It's big, it redefines types with the same names from the ledger, it has a complex witness system, it has historical quirks. This PR aims at reducing one of the things you need to understand to contribute to this codebase: patterns. The patterns that are removed by this PR are easily replaced by a few functions calls there and there. This shows on the count of lines changed: it's more deletion (51) than additions (22).
In additions, this barely impacts the CLI, as the corresponding CLI PR shows.
For the record, this PR is a spin-off of this work: #724
Follow-up
If this one obtains support, I can go further and delete more patterns. Up to reviewers to tell me which direction to go.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist