Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create devcontainer.json to enable GitHub CodeSpaces #466

Closed
wants to merge 2 commits into from

Conversation

yvan-sraka
Copy link
Contributor

@yvan-sraka yvan-sraka commented Feb 27, 2024

Changelog

- description: |
    Add VSCode DevContainer / GitHub CodeSpaces configuration
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

How to trust this PR

Checkout the branch in VSCode, then Ctrl+P "Dev Containers: Reopen in Container" (you should have the Docker daemon running on your machine), then build the project from the integrated terminal.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@yvan-sraka yvan-sraka requested a review from angerman February 27, 2024 08:42
@yvan-sraka yvan-sraka self-assigned this Feb 27, 2024
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
…on_certificate_desc

Fix description of `vote-delegation-certificate` command
Copy link

github-actions bot commented May 1, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added Stale and removed Stale labels May 1, 2024
@yvan-sraka yvan-sraka removed their assignment Jun 13, 2024
@palas
Copy link
Contributor

palas commented Jul 5, 2024

FYI: Because we now enforce the use of cabal-gild to format cabal files and, in order to reduce the amount of hassle, I have cherry-picked the appropriate commit into your PR. This will make the cabal-gild CI check pass for the PR. The commit should be discarded automatically as soon as you either rebase or merge the PR (since it is already in the main branch). Feel free to discard it if you want, but that will make the new required action to fail until you rebase.

@palas palas force-pushed the devcontainer branch 2 times, most recently from b98ff52 to 9db4165 Compare July 6, 2024 01:59
@palas
Copy link
Contributor

palas commented Jul 6, 2024

FYI: I have rebased your branch because we have done changes to the formatting. I have made a copy of the unrebased branch here: backup/devcontainer

Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Aug 21, 2024
Copy link

This issue was closed because it has been stalled for 60 days with no activity.

@github-actions github-actions bot closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants