Fix generated textEnvelope type on registering a Stake Address Registration Certificate

[felix-lipski]

Changelog

- description: |
    split cases in textEnvelopeType
    account for eras after conway using forEraInEon
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes the issue #465 in cardano-cli

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[smelc]

LGTM (nice usage of forEraInEon 👏), but could we had a golden test to make sure we keep track of this bug?

Relevant doc to write the tests:

• https://docs.cardano.org/learn/cardano-keys/
• https://iohk.zendesk.com/hc/en-us/articles/900001219883-Generating-payment-staking-keys-and-address
• https://cardano.stackexchange.com/questions/7787/how-to-delegate-to-a-stake-pool-using-cli

[Jimbo4350]

LGTM 🎉. Can you squash your commits?

[gitmachtl]

did a test with cli8.16.0.1 by manually changing the textEnvelope type to CertificateConway for a deregistration certificate. resulted in an error during the transaction build-raw action:

TextEnvelope type error: Expected: CertificateShelley Actual: CertificateConway

so it looks like the cli is not aware of this type name yet for processing a deregistration certificate. and i guess its the same for the registration certificate aswell.

[felix-lipski]

LGTM (nice usage of forEraInEon 👏), but could we had a golden test to make sure we keep track of this bug?

Relevant doc to write the tests:

• https://docs.cardano.org/learn/cardano-keys/
• https://iohk.zendesk.com/hc/en-us/articles/900001219883-Generating-payment-staking-keys-and-address
• https://cardano.stackexchange.com/questions/7787/how-to-delegate-to-a-stake-pool-using-cli

Golden tests done in cli: IntersectMBO/cardano-cli#499