waiting time decreased #13716
Draft
waiting time decreased #13716
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Jan 29, 2025
| @@ -143,7 +143,7 @@ rsdds_device_factory::rsdds_device_factory( std::shared_ptr< context > const & c | |||
| .default_value( 5 ); | |||
| domain.query_devices_min | |||
| = dds_settings.nested( std::string( "query-devices-min", 17 ), &json::is_number_integer ) | |||
There was a problem hiding this comment.
General questions
Any idea what -min means?
minimum timeout?
What is 17?
What is 3-->0 used for?
There was a problem hiding this comment.
- min is the time the listener waits for new dds participant
- 17 is just the number of characters in the "query-devices-min" string - only syntax needed for the nested method
- 3-->0 has been tried so that the listener will not wait 3 seconds for nothing
See ticket for reason why this PR has been changed to draft.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDEV-3019