COMP: ISO C++17 does not allow dynamic exception #48
Conversation
hjmjohnson
force-pushed
the
dynamic-exceptions-cxx17
branch
2 times, most recently
from
0b7dc90 to
8cccf8b
Compare
There was a problem hiding this comment.
The CI is not being able to run because the default branch needs to be renamed to main: I asked Hans privately if I can proceed.
https://github.com/InsightSoftwareConsortium/LesionSizingToolkit/blob/master/.github/workflows/build-test-package.yml#L6
Also, it may still fail due to the TIFF library issues steming from ITK:
https://open.cdash.org/viewBuildError.php?buildid=10048610
We'll see after I rename the branch.
But changes look OK to me.
|
I have renamed the default branch. Builds have been triggered for |
LesionSizingToolkit/src/itkCannyEdgeDetectionImageFilter2.cxx:30:
LesionSizingToolkit/include/itkCannyEdgeDetectionRecursiveGaussianImageFilter.h:201:34: error: ISO C++17 does not allow dynamic exception specifications [-Wdynamic-exception-spec]
201 | GenerateInputRequestedRegion() throw(InvalidRequestedRegionError) override;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LesionSizingToolkit/include/itkCannyEdgeDetectionRecursiveGaussianImageFilter.h:201:34: note: use 'noexcept(false)' instead
201 | GenerateInputRequestedRegion() throw(InvalidRequestedRegionError) override;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| noexcept(false)
Prefer inintialization to assignment. Ignoring return value of function declared with 'nodiscard' attribute
The sigmoidAlpha value was not tested in the copied and pasted code that was not properly modified.
jhlegarreta
force-pushed
the
dynamic-exceptions-cxx17
branch
from
8cccf8b to
76247aa
Compare
|
CMake config step is failing because |
|
Isn't that option off by default? LesionSizingToolkit/CMakeLists.txt Line 13 in a335394 |
|
Ah, this: LesionSizingToolkit/itk-module.cmake Line 20 in fa1a783 should be conditional upon LSTK_USE_VTK.
|
LesionSizingToolkit/src/itkCannyEdgeDetectionImageFilter2.cxx:30: LesionSizingToolkit/include/itkCannyEdgeDetectionRecursiveGaussianImageFilter.h:201:34: error: ISO C++17 does not allow dynamic exception specifications [-Wdynamic-exception-spec]
201 | GenerateInputRequestedRegion() throw(InvalidRequestedRegionError) override;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LesionSizingToolkit/include/itkCannyEdgeDetectionRecursiveGaussianImageFilter.h:201:34: note: use 'noexcept(false)' instead
201 | GenerateInputRequestedRegion() throw(InvalidRequestedRegionError) override;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| noexcept(false)