Skip to content

Commit

Permalink
COMP: ISO C++17 does not allow dynamic exception
Browse files Browse the repository at this point in the history
LesionSizingToolkit/src/itkCannyEdgeDetectionImageFilter2.cxx:30:
LesionSizingToolkit/include/itkCannyEdgeDetectionRecursiveGaussianImageFilter.h:201:34: error: ISO C++17 does not allow dynamic exception specifications [-Wdynamic-exception-spec]
  201 |   GenerateInputRequestedRegion() throw(InvalidRequestedRegionError) override;
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
LesionSizingToolkit/include/itkCannyEdgeDetectionRecursiveGaussianImageFilter.h:201:34: note: use 'noexcept(false)' instead
  201 |   GenerateInputRequestedRegion() throw(InvalidRequestedRegionError) override;
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                  noexcept(false)
  • Loading branch information
hjmjohnson committed Nov 25, 2024
1 parent bec32f3 commit 6ec1086
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ class ITK_TEMPLATE_EXPORT CannyEdgeDetectionRecursiveGaussianImageFilter
*
* \sa ImageToImageFilter::GenerateInputRequestedRegion() */
void
GenerateInputRequestedRegion() throw(InvalidRequestedRegionError) override;
GenerateInputRequestedRegion() noexcept(false) override;

#ifdef ITK_USE_CONCEPT_CHECKING
/** Begin concept checking */
Expand Down
4 changes: 2 additions & 2 deletions include/itkCannyEdgeDetectionRecursiveGaussianImageFilter.hxx
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ CannyEdgeDetectionRecursiveGaussianImageFilter<TInputImage, TOutputImage>::Alloc

template <typename TInputImage, typename TOutputImage>
void
CannyEdgeDetectionRecursiveGaussianImageFilter<TInputImage, TOutputImage>::GenerateInputRequestedRegion() throw(
InvalidRequestedRegionError)
CannyEdgeDetectionRecursiveGaussianImageFilter<TInputImage, TOutputImage>::GenerateInputRequestedRegion() noexcept(
false)
{
// call the superclass' implementation of this method
Superclass::GenerateInputRequestedRegion();
Expand Down
2 changes: 1 addition & 1 deletion include/itkLesionSegmentationImageFilter8.h
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class LesionSegmentationImageFilter8 : public ImageToImageFilter<TInputImage, TO
using SigmaArrayType = typename CannyEdgesFeatureGeneratorType::SigmaArrayType;

void
GenerateInputRequestedRegion() throw(InvalidRequestedRegionError) override;
GenerateInputRequestedRegion() noexcept(false) override;

#ifdef ITK_USE_CONCEPT_CHECKING
/** Begin concept checking */
Expand Down
3 changes: 1 addition & 2 deletions include/itkLesionSegmentationImageFilter8.hxx
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ LesionSegmentationImageFilter8<TInputImage, TOutputImage>::LesionSegmentationIma

template <typename TInputImage, typename TOutputImage>
void
LesionSegmentationImageFilter8<TInputImage, TOutputImage>::GenerateInputRequestedRegion() throw(
InvalidRequestedRegionError)
LesionSegmentationImageFilter8<TInputImage, TOutputImage>::GenerateInputRequestedRegion() noexcept(false)
{
// call the superclass' implementation of this method
Superclass::GenerateInputRequestedRegion();
Expand Down

0 comments on commit 6ec1086

Please sign in to comment.