Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add SmoothImageWithDiscreteGaussianFilter python example #372

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RomanFenioux
Copy link

No description provided.

@github-actions github-actions bot added area:Documentation Issues affecting the Documentation module area:Filtering Issues affecting the Filtering module language:Python Changes to Python examples type:Enhancement Improvement of existing methods or implementation labels May 20, 2022
@tbirdso tbirdso self-requested a review May 20, 2022 13:52
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Please see comments for Pythonic equivalents of ITK filters.

Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomanFenioux well done!!

CI is failing because it expects an image for the test.

Exception detected while reading /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png : 
itk::ImageFileReaderException (0x5594a8e5f4d0)
Location: "unknown" 
File: /home/runner/work/bld/ITK/Modules/IO/ImageBase/include/itkImageFileReader.hxx
Line: 132
Description:  Could not create IO object for reading file /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png
The file doesn't exist. 
Filename = /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png



Exception detected while reading /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png : 
itk::ImageFileReaderException (0x5594a8e5d740)
Location: "unknown" 
File: /home/runner/work/bld/ITK/Modules/IO/ImageBase/include/itkImageFileReader.hxx
Line: 132
Description:  Could not create IO object for reading file /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png
The file doesn't exist. 
Filename = /home/runner/work/bld/ITKEx-build/src/Filtering/Smoothing/SmoothImageWithDiscreteGaussianFilter/SmoothImageWithDiscreteGaussianFilterPython.png

For more information on how to add this image, please see the other examples and the documentation here: https://examples.itk.org/documentation/contribute/uploadbinarydata

@github-actions github-actions bot added the type:Data Changes to example data (usually displayed images) label May 20, 2022
@RomanFenioux
Copy link
Author

Hi @thewtex
I see the CI failed again and I'm not sure why.
I found an itk::InvalidRequestedRegionError in the logs and I'm guessing this is still related to the input issue but maybe you have an idea about what could be causing this ?
Thanks for your help

@thewtex thewtex dismissed their stale review May 23, 2022 16:58

Updates added

@thewtex
Copy link
Member

thewtex commented May 23, 2022

Hi @RomanFenioux looking great!

Could you please rebase on master -- there were package improvements unrelated to your patch that may be causing issues in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Documentation Issues affecting the Documentation module area:Filtering Issues affecting the Filtering module language:Python Changes to Python examples type:Data Changes to example data (usually displayed images) type:Enhancement Improvement of existing methods or implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants