Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Build manylinux2014 wheels by default #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ENH: Build manylinux2014 wheels by default #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/dockcross-manylinux-build-module-wheels.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@
# These variables are set with the `export` bash command before calling the script.#
# For example,
#
# export MANYLINUX_VERSION="_2_28"
# export MANYLINUX_VERSION="2014"
# scripts/dockcross-manylinux-build-module-wheels.sh cp39
#
# `LD_LIBRARY_PATH`: Shared libraries to be included in the resulting wheel.
# For instance, `export LD_LIBRARY_PATH="/path/to/OpenCL.so:/path/to/OpenCL.so.1.2"`
#
# `MANYLINUX_VERSION`: Specialized manylinux image to use for building. Default is _2_28.
# `MANYLINUX_VERSION`: Specialized manylinux image to use for building. Default is 2014.
# See https://github.com/dockcross/dockcross for available versions and tags.
# For instance, `export MANYLINUX_VERSION=2014`
# For instance, `export MANYLINUX_VERSION=_2_28`
#
# `TARGET_ARCH`: Target architecture for which wheels should be built.
# For instance, `export MANYLINUX_VERSION=aarch64`
Expand Down
2 changes: 1 addition & 1 deletion scripts/dockcross-manylinux-build-wheels.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# scripts/dockcross-manylinux-build-module-wheels.sh cp39
#

MANYLINUX_VERSION=${MANYLINUX_VERSION:=_2_28}
MANYLINUX_VERSION=${MANYLINUX_VERSION:=2014}

if [[ ${MANYLINUX_VERSION} == _2_28 ]]; then
IMAGE_TAG=${IMAGE_TAG:=20230106-1aeaea0}
Expand Down
2 changes: 1 addition & 1 deletion scripts/dockcross-manylinux-download-cache.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ ${unzstd_exe} --version
# -----------------------------------------------------------------------
# Fetch build archive

MANYLINUX_VERSION=${MANYLINUX_VERSION:=_2_28}
MANYLINUX_VERSION=${MANYLINUX_VERSION:=2014}
TARGET_ARCH=${TARGET_ARCH:=x64}

case ${TARGET_ARCH} in
Expand Down
4 changes: 2 additions & 2 deletions scripts/dockcross-manylinux-set-vars.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ ITKPYTHONPACKAGE_TAG=${ITKPYTHONPACKAGE_TAG:=master}
########################################################################
# Docker image parameters

# Specialized manylinux image to use for building. Default is _2_28.
# Specialized manylinux image to use for building. Default is 2014.
# See https://github.com/dockcross/dockcross for available versions and tags.
MANYLINUX_VERSION=${MANYLINUX_VERSION:=_2_28}
MANYLINUX_VERSION=${MANYLINUX_VERSION:=2014}

# Target platform architecture (x64, aarch64)
TARGET_ARCH=${TARGET_ARCH:=x64}
Expand Down
2 changes: 1 addition & 1 deletion scripts/internal/manylinux-build-common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,6 @@ if ! type ninja > /dev/null 2>&1; then
popd
fi

MANYLINUX_VERSION=${MANYLINUX_VERSION:=_2_28}
MANYLINUX_VERSION=${MANYLINUX_VERSION:=2014}

echo "Building wheels for $ARCH using manylinux${MANYLINUX_VERSION}"