windows: Add basic argument parsing to driver script #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix related bugs.
jcfr
reviewed
Nov 1, 2018
| @@ -148,7 +150,8 @@ def build_wheel(python_version, single_wheel=False, | |||
| "-DITK_BINARY_DIR:PATH=%s" % build_path, | |||
| "-DPYTHON_EXECUTABLE:FILEPATH=%s" % python_executable, | |||
| "-DPYTHON_INCLUDE_DIR:PATH=%s" % python_include_dir, | |||
| "-DPYTHON_LIBRARY:FILEPATH=%s" % python_library | |||
| "-DPYTHON_LIBRARY:FILEPATH=%s" % python_library, | |||
| "-DDOXYGEN_EXECUTABLE:FILEPATH=C:/P/doxygen/doxygen.exe", | |||
There was a problem hiding this comment.
May be "-DDOXYGEN_EXECUTABLE:FILEPATH=C:/P/doxygen/doxygen.exe" could be conditionally specified is optional .. or an exception could be raised early if not available ?
There was a problem hiding this comment.
Yes, we can do more with Doxygen. I created #116 to track it.
|
Beside of one nitpick. 👍 |
|
@jcfr thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix related bugs.