STYLE: Replace thread_local path with internal MakePath function
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzenanz
approved these changes
Aug 26, 2024
Aims to reduce "common coupling" between functions.
N-Dekker
force-pushed
the
Replace-path-with-MakePath
branch
from
4710b37 to
d1f8b44
Compare
N-Dekker
changed the title
path with local MakePath helper functionpath with internal MakePath function
|
FYI, I changed the subject because the term "local helper function" appears somewhat unclear, in C++. |
|
@dzenanz Thanks for your approval! I also think this pull request is ready now! |
dzenanz
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to reduce common coupling between functions.