Add tibial_cartilage_cropped test case in C++ and Python #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzenanz
commented
Nov 27, 2024
wrapping/test/CMakeLists.txt
Outdated
| EXPRESSION "filter = itk.CuberilleImageToMeshFilter.New()" | ||
| ) | ||
|
|
||
| set(test_input_dir ${CMAKE_CURRENT_SOURCE_DIR}/../../test/Input) |
There was a problem hiding this comment.
@blowekamp I was unable to get ${itk-module} from InsightSoftwareConsortium/ITK@7d50786 to work here. Is there a prettier way to construct this?
wrapping/test/CMakeLists.txt
Outdated
| TEST_DRIVER_ARGS | ||
| COMMAND cuberille_test.py | ||
| DATA{${test_input_dir}/tibial_cartilage_cropped.nrrd} | ||
| ${ITK_TEST_OUTPUT_DIR}/tibial_cartilage_cropped.vtk |
There was a problem hiding this comment.
@blowekamp How to add module subdirectory here?
dzenanz
force-pushed
the
tcCrash
branch
4 times, most recently
from
54d9f86 to
15ccc1d
Compare
|
@yehan0223 will look into this. |
|
Some notes: Changing isosurface value to 0.1 will successfully create mesh below. Setting it to 0.5 will cause topological issue (corner case) with error message This can potentially be fixed by changing one of the labelarray ( ), as some of the labels were changed from 0 to 1, 2 or 3 to handle corner cases in the existing tests which otherwise would incur the same error message above.
whole model with isosurfacevalue = 0.1 |
It also produces an unstable number of points, and sometimes even cells (triangles).
The number of points is unstable, varying from 526 to 532.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a an input which causes crash in Python, and generates an empty mesh in C++.