Move empty member function definitions from "itk*.hxx" to "itk*.h" #5198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Core
Found by regular expression `::.+\(\)\r\n{}` in "itk*.hxx" files
Suggested by Denis Shamonin.
Moved the member function definitions of member functions that have an empty
parameter list and an empty member function definition from their "itk*.hxx"
file to the corresponding "itk*.h" file, and into their class definition.
Found by regular expression `::.+\(\)\r\n{}` in "itk*.hxx" files.
Suggested by Denis Shamonin.
N-Dekker
force-pushed
the
Move-empty-member-function-definitions-to-h
branch
from
53eb106 to
b94770d
Compare
dzenanz
approved these changes
Jan 29, 2025
|
The test failure of itkConvolutionImageFilterStreamingValidTest at https://open.cdash.org/viewTest.php?onlyfailed&buildid=10177192 looks unrelated to me. It says: |
|
/azp run ITK.Windows |
jhlegarreta
merged commit b87a8b0
into
InsightSoftwareConsortium:master
15 checks passed
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Feb 1, 2025
Moved the member function definitions of member functions that have an empty
member function definition from their "itk*.hxx" file to the corresponding
"itk*.h" file, and into their class definition.
Found by regular expression `^..[^:,].+\)\r\n{}` in "itk*.hxx" files.
- Follow-up to pull request InsightSoftwareConsortium#5198
commit b94770d
"STYLE: Move empty member functions with empty param list from .hxx to .h"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the member function definitions of member functions that have an empty
parameter list and an empty member function definition from their "itk*.hxx"
file to the corresponding "itk*.h" file, and into their class definition.
Defaulted the default-constructor of
PyImageFilter.Found by regular expression
::.+\(\)\r\n{}in "itk*.hxx" files.Suggested by Denis Shamonin (@dpshamonin).