Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Type matching for complex pixel data types #5188

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

hjmjohnson
Copy link
Member

Modules/Filtering/ImageCompose/include/itkComposeImageFilter.hxx:135:19: error: non-constant-expression cannot be narrowed from type 'PixelType' (aka 'unsigned char') to 'float' in initializer list [-Wc++11-narrowing]
135 | oit.Set({ inputItContainer[0].Get(), inputItContainer[1].Get() });
| ^~~~~~~~~~~~~~~~~~~~~~~~~

Identified when building SphinxExamples remote module.

PR Checklist

Modules/Filtering/ImageCompose/include/itkComposeImageFilter.hxx:135:19: error: non-constant-expression cannot be narrowed from type 'PixelType' (aka 'unsigned char') to 'float' in initializer list [-Wc++11-narrowing]
  135 |         oit.Set({ inputItContainer[0].Get(), inputItContainer[1].Get() });
      |                   ^~~~~~~~~~~~~~~~~~~~~~~~~

Identified when building SphinxExamples remote module.
@github-actions github-actions bot added type:Compiler Compiler support or related warnings area:Filtering Issues affecting the Filtering module labels Jan 26, 2025
@hjmjohnson hjmjohnson requested a review from blowekamp January 26, 2025 23:39
@hjmjohnson hjmjohnson self-assigned this Jan 26, 2025
@hjmjohnson hjmjohnson merged commit eeb6235 into master Jan 27, 2025
16 checks passed
@hjmjohnson hjmjohnson deleted the fix-narrowing-bug branch January 27, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Filtering Issues affecting the Filtering module type:Compiler Compiler support or related warnings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants