-
-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST: Fix unexercised tests for large image read/write #5151
base: master
Are you sure you want to change the base?
TEST: Fix unexercised tests for large image read/write #5151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing a pull request! 🙏
Welcome to the ITK community! 🤗👋☀️
We are glad you are here and appreciate your contribution. Please keep in mind our community participation guidelines. 📜
More support and guidance on the contribution process can be found in our contributing guide. 📖
This is an automatic message. Allow for time for the ITK community to be able to read the pull request and comment
on it.
ITK doesn't recognize |
7d057cb
to
83bfcfe
Compare
Updated the commit msg to use ENH |
itkLargeImageWriteReadTest | ||
${ITK_TEST_OUTPUT_DIR}/itkLargeImageWriteReadTest_3D.mha | ||
30000L | ||
4L) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like each of these tests needs 5 GB of memory and can not be run concurrently on memory constrained system. Please add something like the following for each memory intensive test:
set_tests_properties(itkComposeBigVectorImageFilterTest
PROPERTIES
RESOURCE_LOCK
MEMORY_SIZE)
This will ensure only one test with "MEMORY_SIZE" resource constrained is run at a time.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.
Closes: #3703