Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Fix unexercised tests for large image read/write #5151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jadh4v
Copy link
Member

@jadh4v jadh4v commented Jan 23, 2025

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

Closes: #3703

@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:IO Issues affecting the IO module labels Jan 23, 2025
@jadh4v jadh4v changed the title TEST: Fix uncalled tests for large image read/write TEST: Fix unexercised tests for large image read/write Jan 23, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing a pull request! 🙏

Welcome to the ITK community! 🤗👋☀️

We are glad you are here and appreciate your contribution. Please keep in mind our community participation guidelines. 📜
More support and guidance on the contribution process can be found in our contributing guide. 📖

This is an automatic message. Allow for time for the ITK community to be able to read the pull request and comment
on it.

@dzenanz
Copy link
Member

dzenanz commented Jan 23, 2025

ITK doesn't recognize TEST: prefix, so you should use ENH: in the commit message. Otherwise looks good.

@jadh4v jadh4v force-pushed the TESTS-fix-uncalled-large-image-read-write-tests branch from 7d057cb to 83bfcfe Compare January 23, 2025 18:39
@jadh4v
Copy link
Member Author

jadh4v commented Jan 23, 2025

ITK doesn't recognize TEST: prefix, so you should use ENH: in the commit message. Otherwise looks good.

Updated the commit msg to use ENH

itkLargeImageWriteReadTest
${ITK_TEST_OUTPUT_DIR}/itkLargeImageWriteReadTest_3D.mha
30000L
4L)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like each of these tests needs 5 GB of memory and can not be run concurrently on memory constrained system. Please add something like the following for each memory intensive test:

   set_tests_properties(itkComposeBigVectorImageFilterTest
            PROPERTIES
            RESOURCE_LOCK
            MEMORY_SIZE)

This will ensure only one test with "MEMORY_SIZE" resource constrained is run at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:IO Issues affecting the IO module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IO ImageBase tests not exercised
3 participants