BUG: Fixed strict weak ordering for itkIPLFileNameList.cxx descend co… #5126
Conversation
github-actions
bot
added
type:Bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for contributing a pull request! 🙏
Welcome to the ITK community! 🤗👋☀️
We are glad you are here and appreciate your contribution. Please keep in mind our community participation guidelines. 📜
More support and guidance on the contribution process can be found in our contributing guide. 📖
This is an automatic message. Allow for time for the ITK community to be able to read the pull request and comment
on it.
|
@N-Dekker @dzenanz @thewtex : @ctaylo41 here is our intern this semester, and he's trying this with our code and dependencies: https://libcxx.llvm.org/Hardening.html |
|
Overflow from the overly long first line spilling into second line in commit message is what makes ghostflow unhappy. Shortening the first line to be <72 characters seems like an obvious solution. |
- Changed type of ascend and descend compare method from int to bool - Fixed subtraction is not comparison for both ascend and descend comparator - Fixed strict weak odering for descend comparator which was found using libc++ hardening mode in the debug setting - Changed name of ascend and descend comparator from qsort to remove confussion as qsort outputs -1,0,1 vs sort 0,1
|
I added a blank line in the commit message via force-push. ghostflow is now green. |
dzenanz
merged commit 78f14df
into
InsightSoftwareConsortium:master
…mpare