Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Castxml linux arm #4573

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Apr 11, 2024

No description provided.

thewtex added 2 commits April 11, 2024 12:19
Addresses:

> cc1plus: fatal error: /work/ITK-cp311-cp311-manylinux_2_28_aarch64/Wrapping/Generators/CastXML/castxml/share/castxml/empty.cpp: No such file or directory

Built with CastXMLSuperbuild 85ee6dc2abeec58c6769b2b7d3236696ac4f0a1d.
To address:

/work/ITK-cp310-cp310-manylinux_2_28_aarch64/Wrapping/Typedefs/itkVnlForward1DFFTImageFilter.i:469: Warning 401: Maybe you forgot to instantiate 'itk::Forward1DFFTImageFilter< itk::Image< float,4 >,itk::Image< std::complex< float >,4 > >' using %template.

Also the non-1D classes.
@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:Python wrapping Python bindings for a class area:Filtering Issues affecting the Filtering module labels Apr 11, 2024
thewtex added 2 commits April 11, 2024 15:45
Address build errors on Linux Aarch64, e.g.:

/work/ITK-cp310-cp310-manylinux_2_28_aarch64/Wrapping/Typedefs/itkVnlForward1DFFTImageFilter.i:469: Warning 401: Maybe you forgot to instantiate 'itk::Forward1DFFTImageFilter< itk::Image< float,4 >,itk::Image< std::complex< float >,4 > >' using %template.
To address on ARM Linux wrapping:

FAILED: Wrapping/Modules/ITKLabelMap/itkStatisticsLabelMapFilterPython.cpp Wrapping/Generators/Python/itk/itkStatisticsLabelMapFilterPython.py /work/ITK-cp310-cp310-manylinux_2_28_aarch64/Wrapping/Modules/ITKLabelMap/itkStatisticsLabelMapFilterPython.cpp /work/ITK-cp310-cp310-manylinux_2_28_aarch64/Wrapping/Generators/Python/itk/itkStatisticsLabelMapFilterPython.py
cd /work/ITK-cp310-cp310-manylinux_2_28_aarch64/Wrapping/Typedefs/python && /work/ITK-cp310-cp310-manylinux_2_28_aarch64/Wrapping/Generators/SwigInterface/swiglinux-arm64-2024-03-26-master/bin/swig -c++ -python -fastdispatch -fvirtual -features autodoc=2 -doxygen -Werror -w302 -w303 -w312 -w314 -w361 -w362 -w350 -w383 -w384 -w389 -w394 -w395 -w467 -w508 -w509 -o /work/ITK-cp310-cp310-manylinux_2_28_aarch64/Wrapping/Modules/ITKLabelMap/itkStatisticsLabelMapFilterPython.cpp -I/work/ITK-cp310-cp310-manylinux_2_28_aarch64/Wrapping/Generators/SwigInterface/swiglinux-arm64-2024-03-26-master/share/swig/4.3.0/python -I/work/ITK-cp310-cp310-manylinux_2_28_aarch64/Wrapping/Generators/SwigInterface/swiglinux-arm64-2024-03-26-master/share/swig/4.3.0 -I/work/ITK-source/ITK/Wrapping/Generators -I/work/ITK-cp310-cp310-manylinux_2_28_aarch64/Wrapping/Typedefs/python -I/work/ITK-cp310-cp310-manylinux_2_28_aarch64/Wrapping/Typedefs -outdir /work/ITK-cp310-cp310-manylinux_2_28_aarch64/Wrapping/Generators/Python/itk /work/ITK-cp310-cp310-manylinux_2_28_aarch64/Wrapping/Typedefs/itkStatisticsLabelMapFilter.i
/work/ITK-cp310-cp310-manylinux_2_28_aarch64/Wrapping/Typedefs/itkStatisticsLabelMapFilter.i:87: Warning 401: Nothing known about base class 'itk::ShapeLabelMapFilter< itk::LabelMap< itk::StatisticsLabelObject< unsigned long,2 > >,itk::Image< unsigned long > >'. Ignored.
@thewtex thewtex force-pushed the castxml-linux-arm branch from dff65d4 to b61d4ed Compare April 11, 2024 21:36
To address:

/work/ITK-cp310-cp310-manylinux_2_28_aarch64/Wrapping/Typedefs/itkNarrowBandCurvesLevelSetImageFilter.i:84: Warning 401: Nothing known about base class 'itk::NarrowBandLevelSetImageFilter< itk::Image< double >,itk::Image< double >,double,itk::Image< double > >'. Ignored.

on Linux aarch64.
@github-actions github-actions bot added the area:Segmentation Issues affecting the Segmentation module label Apr 11, 2024
@thewtex thewtex marked this pull request as ready for review April 12, 2024 12:06
@thewtex thewtex requested a review from phcerdan April 12, 2024 12:06
Copy link
Member

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems with this.

@thewtex thewtex merged commit ac17ed0 into InsightSoftwareConsortium:master Apr 12, 2024
13 checks passed
@thewtex thewtex deleted the castxml-linux-arm branch April 12, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Filtering Issues affecting the Filtering module area:Python wrapping Python bindings for a class area:Segmentation Issues affecting the Segmentation module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants