COMP: Numerical computation precision limit in resampling #4570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjmjohnson
added
the
type:Testing
github-actions
bot
added
type:Compiler
hjmjohnson
force-pushed
the
fix-arm64-test-failure
branch
from
5b19184 to
90eae4f
Compare
github-actions
bot
added
area:Python wrapping
Coordinate computations for nearest neighbor are computed at the limits of numerical precision for this image during resampling. arm64 and x86_64 compute input continuous index coordinates as 105.39999999999999 vs 105.4 which requires a slight tolerance acceptance in the comparisons Add --compareRadiusTolerance 1 to test validation.
hjmjohnson
force-pushed
the
fix-arm64-test-failure
branch
from
90eae4f to
209e324
Compare
github-actions
bot
removed
area:Python wrapping
dzenanz
approved these changes
Apr 10, 2024
|
@hjmjohnson did you accidentally deleted this branch? And possibly also #4571? |
Yes! Thank you for alerting me. |
hjmjohnson
merged commit 877acba
into
InsightSoftwareConsortium:master
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coordinate computations for nearest neighbor are computed at the limits of numerical precision for this image during resampling. arm64 and x86_64 compute input continuous index coordinates as 105.39999999999999 vs 105.4 which requires a slight tolerance acceptance in the comparisons
Add --compareRadiusTolerance 1 to test validation.
https://open.cdash.org/tests/1506666894
PR Checklist