-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to include Mkdocs skeleton and GitHub workflow #68
Conversation
e0b87a3
to
e4fd0ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a few suggested changes. Some are opinions, others are required. I've tried to make it clear which is which.
Co-authored-by: Adrian D'Alessandro <[email protected]>
Co-authored-by: Adrian D'Alessandro <[email protected]>
@AdrianDAlessandro I decided to go with your suggestion of building the docs only on release. I think that's probably a more sensible default and users can always tweak it later if they want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll open an issues about the timeouts
Thanks 😄 |
Most of this was copied from other places where we use these config files, so hopefully there's nothing too controversial here.
I've added an option to add a MkDocs skeleton along with a GitHub workflow to deploy it to GitHub Pages (using the new workflow, like we do with the blog). Annoyingly, it seems like you can't have some prompts that depend on others with
cookiecutter
, so users have to either take the lot or nothing at all. Oh well.I also removed some irrelevant parts of the README for
pip-tools
projects and enabled caching for Python packages with GitHub Actions.Closes #61.