Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to include Mkdocs skeleton and GitHub workflow #68

Merged
merged 13 commits into from
Aug 12, 2024
Merged

Conversation

alexdewar
Copy link
Collaborator

@alexdewar alexdewar commented Aug 6, 2024

Most of this was copied from other places where we use these config files, so hopefully there's nothing too controversial here.

I've added an option to add a MkDocs skeleton along with a GitHub workflow to deploy it to GitHub Pages (using the new workflow, like we do with the blog). Annoyingly, it seems like you can't have some prompts that depend on others with cookiecutter, so users have to either take the lot or nothing at all. Oh well.

I also removed some irrelevant parts of the README for pip-tools projects and enabled caching for Python packages with GitHub Actions.

Closes #61.

@alexdewar alexdewar force-pushed the mkdocs branch 3 times, most recently from e0b87a3 to e4fd0ce Compare August 6, 2024 11:29
@alexdewar alexdewar marked this pull request as ready for review August 6, 2024 11:38
Copy link
Contributor

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few suggested changes. Some are opinions, others are required. I've tried to make it clear which is which.

@alexdewar
Copy link
Collaborator Author

@AdrianDAlessandro I decided to go with your suggestion of building the docs only on release. I think that's probably a more sensible default and users can always tweak it later if they want.

Copy link
Contributor

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll open an issues about the timeouts

@alexdewar
Copy link
Collaborator Author

Thanks 😄

@alexdewar alexdewar merged commit 0f9ed4a into main Aug 12, 2024
9 checks passed
@alexdewar alexdewar deleted the mkdocs branch August 12, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mkdocs into repository
2 participants