Add a CODEOWNERS file #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalonsoa
approved these changes
Jul 16, 2024
|
Will this mean any python projects that use this templates get this same CODEOWNERS file? Would it be a good idea to provide this option in the cookiecutter setup questions? |
|
I don't think so because the files/folders copied by people using this tool - which is not really a template repository as the other two we have - will be these: https://github.com/ImperialCollegeLondon/python-template/tree/main/%7B%7B%20cookiecutter.project_slug%20%7D%7D |
|
Yep, exactly. |
|
@cc-a Are you happy with this? |
|
Sure, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a CODEOWNERS file to this repo, which lists who should be automatically tagged for reviewing PRs and I've tagged the people who usually review these sorts of PRs. We can also set things up so that x number of code owners must approve PRs, but I'm really just doing this to make sure that the relevant people get tagged.
This is partly just an RFC, so if you think it's a bad idea in general, then please say. Also please say if you don't want to be a code owner!