Fix codespell arg #137
Merged
Fix codespell arg #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that -L lets you provide a list of words to ignore *on the command line*. What we actually want is to provide a file with a list of words to be ignored. The correct option for this is -I. The reason we didn't notice is because the file is currently empty, but it will be frustrating for whoever actually tries to add something to it!
alexdewar
added a commit
to ImperialCollegeLondon/drunc_ui
that referenced
this pull request
Oct 17, 2024
It turns out that -L lets you provide a list of words to ignore on the command line. What we actually want is to provide a file with a list of words to be ignored. The correct option for this is -I. See: ImperialCollegeLondon/python-template#137
alexdewar
added a commit
to alexdewar/imperial_coldfront_plugin
that referenced
this pull request
Oct 17, 2024
It turns out that -L lets you provide a list of words to ignore on the command line. What we actually want is to provide a file with a list of words to be ignored. The correct option for this is -I. See: ImperialCollegeLondon/python-template#137
dalonsoa
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that -L lets you provide a list of words to ignore on the command line. What we actually want is to provide a file with a list of words to be ignored. The correct option for this is -I.
The reason we didn't notice is because the file is currently empty, but it will be frustrating for whoever actually tries to add something to it!