-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pytest-mypy #136
Remove pytest-mypy #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same error you already know.
.github/workflows/ci-pip-tools.yml
Outdated
@@ -36,6 +36,10 @@ jobs: | |||
working-directory: my_project | |||
run: pip install .[dev] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that installing this in editable mode should solve the issues. True, it is not needed, but it causes no harm and might be useful to keep mypy happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made two separate pushes to confirm everything passes and fails as we expect. I have no idea why installing in editable mode fixes this.
I also have changed the install the use the pinned dev-requirements so it runs the same in this repo as in any repos that use this template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, but on the whole seems sensible.
Description
This removes
pytest-mypy
because of the issue with test discovery in the vscode extension. To make up for it, mypy has bee added to CI.There is a chance the CI tests will fail because of either the
run: pip install .[dev]
makingmypy .
fail, or thetest_version
test causing problems with if we dorun: pip install -r dev-requirements.txt
. So this will need to be resolved either way.Fixes #135
Type of change
Key checklist
python -m pytest
)python -m sphinx -b html docs docs/build
)pre-commit run --all-files
)Further checks