Configure logging #54
Conversation
There was a problem hiding this comment.
pre-commit QA is failing because there is no newline at the end of the file. Add this in for now, but the easiest way to avoid this is to install pre-commit into the virtual environment you're using locally (it is part of the development requirements).
It might be as simple as doing a find-replace from uvicorn -> gunicorn to get that working correctly.
|
I would like you to update all the print statements you can find in the code with either Specifically, do this in |
Co-authored-by: Adrian D'Alessandro <[email protected]>
Co-authored-by: Adrian D'Alessandro <[email protected]>
docker-compose.yml
Outdated
| - 8050:8050 | ||
| volumes: | ||
| - ./app:/app | ||
| - ./logs:/logs |
There was a problem hiding this comment.
Ah sorry, I didn't think properly when I asked you to add this in. You'll have to revert the commit that added this file. The docker-compose.yml isn't tracked by git because it is generated by configure.py so instead you will have to add a line to that python script to include this logs volume. Find where the app volume is added and add it that way. Test if it has worked by running the configure.py script
AdrianDAlessandro
changed the title
…ead of modifying the .yml file itself.
This reverts commit 808cddf.
configure.py
Outdated
| @@ -76,7 +76,7 @@ def generate_docker_compose(template_file: str, ip: str, develop: bool = False) | |||
| } | |||
| if develop: | |||
| docker_compose["services"]["dash"]["build"] = "." | |||
| docker_compose["services"]["dash"]["volumes"] = ["./app:/app"] | |||
| docker_compose["services"]["dash"]["volumes"] = ["./app:/app", "./logs:/logs"] | |||
There was a problem hiding this comment.
Ok, we're almost there. These logs need to be included in the production version as well as the develop version, which means it needs to be added to where docker_compose["services"]["dash"] is defined above this if develop block. But only the logs volume and not the app volume.
I'd suggest adding the something like "volumes": ["./logs:/logs"] to the dictionary above and then changing this line to:
| docker_compose["services"]["dash"]["volumes"] = ["./app:/app", "./logs:/logs"] | |
| docker_compose["services"]["dash"]["volumes"] += ["./app:/app"] |
…velop version, then the app volume will be added as well
Description
The init.py file has been updated to match datahub/init.py.
The log_config.py file has been added to match datahub/core/log_config.py
Close #51
Further checks