Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live model bug #112

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Live model bug #112

merged 2 commits into from
Feb 9, 2024

Conversation

AdrianDAlessandro
Copy link
Collaborator

@AdrianDAlessandro AdrianDAlessandro commented Feb 8, 2024

Description

This PR fixes the issue that prevented the live model / non-develop version running on the server. The changes have already been made on the server. I needed to start the datahub to confirm this works.

Once this is merged a release needs to be made so the newest image is built.

Close #111

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (python -m pytest)
  • Pre-commit hooks run successfully (pre-commit run --all-files)

Copy link
Contributor

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@AdrianDAlessandro AdrianDAlessandro merged commit ed00002 into main Feb 9, 2024
4 checks passed
@AdrianDAlessandro AdrianDAlessandro deleted the live-model-bug branch February 9, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker compose does not like LIVE_MODEL: true
2 participants