Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #103

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Update README.md #103

merged 2 commits into from
Dec 19, 2023

Conversation

AdrianDAlessandro
Copy link
Collaborator

@AdrianDAlessandro AdrianDAlessandro commented Dec 1, 2023

Description

This is the starting point for the documentation review in #99

Close #99

@dalonsoa dalonsoa marked this pull request as ready for review December 19, 2023 16:09
Copy link
Contributor

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping aside the bug described in #111 , and as far as we have tested in the room computer, things seem to work well.

I did not manage to make it work in full in my computer, but I suspect my docker installation is somewhat broken, so not a reliable check.

@dalonsoa dalonsoa merged commit d4d226e into main Dec 19, 2023
4 checks passed
@dalonsoa dalonsoa deleted the docs-review branch December 19, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review (and try) documentation in README - amend if needed
2 participants