Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate(carousel): keyboardSupport #15236

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

deprecate(carousel): keyboardSupport #15236

wants to merge 3 commits into from

Conversation

RivaIvanova
Copy link
Member

@RivaIvanova RivaIvanova commented Jan 14, 2025 •
edited
Loading

Closes #15250

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@rkaraivanov
Copy link
Member

@RivaIvanova
How is that related to #15020?

@RivaIvanova RivaIvanova deleted the rivanova/fix-15020-master branch January 16, 2025 07:58
@RivaIvanova RivaIvanova restored the rivanova/fix-15020-master branch January 16, 2025 08:15
@RivaIvanova RivaIvanova reopened this Jan 16, 2025
@RivaIvanova RivaIvanova changed the title chore(carousel): remove deprecated keyboardSupport deprecate(carousel): keyboardSupport Jan 16, 2025
@RivaIvanova RivaIvanova linked an issue Jan 16, 2025 that may be closed by this pull request
[Carousel]: Remove deprecated keyboardSupport prop #15250
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkaraivanov rkaraivanov Awaiting requested review from rkaraivanov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🎠 carousel version: 19.1.x ❌ status: awaiting-test PRs awaiting manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Carousel]: Remove deprecated keyboardSupport prop
2 participants
@RivaIvanova @rkaraivanov