Refactor for IcingaDB #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This removes all support for converting legacy Icinga Web 1 views. Rationale being that this is likely not a use case any more and it does not need to be supported in the future (i.e. when migrating this to Icinga DB)
- Breaking: changed option names and removed out_of_notification_period option - This migrates the use of the Monitoring Module to Icinga DB Web - Removes CLI Command to convert Icinga 1 TLV - Removes old database models
- Introduced a helper util to limit strings
martialblog
force-pushed
the
feature/icingadb
branch
from
c62d705 to
bb4e3c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the module to use Icinga DB Web.
Fixes #46
Breaking: This migrates the use of the Monitoring module to Icinga DB Web
Based on the amount of users of this module we decided not to support both modules (Monitoring / IcingaDB). A final cleanup for Monitoring module is already released.
Breaking: changed option names and removed out_of_notification_period option
Since a lot of behavior was carried over from the original Icinga 1 TLV module we have decided to remove this, which also makes the view behavior more understandable.
Removes CLI Command to convert Icinga 1 TLV
Legacy code that will no longer be supported, thus we removed it.
Fixes dropdown menu for fullscreen view