Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectImporter: Retransform sync job settings apply_changes from boolean to 'y' or 'n' #2904

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

raviks789
Copy link
Collaborator

@raviks789 raviks789 commented Aug 7, 2024

Sync jobs restored from a basket snapshot with apply_changes settings set to Yes, runs without applying any changes to the objects affected by the sync rule. This happens as the value of the setting is exported as a boolean but is not retransformed back to y or n while importing.

fixes ref/IP/53326

@cla-bot cla-bot bot added the cla/signed label Aug 7, 2024
@raviks789 raviks789 self-assigned this Aug 8, 2024
@raviks789 raviks789 added this to the v1.11.2 milestone Aug 13, 2024
@raviks789 raviks789 marked this pull request as ready for review October 22, 2024 08:49
@raviks789 raviks789 force-pushed the fix/basket-restore-sync-job branch 2 times, most recently from 8fa811c to 82c03a2 Compare October 22, 2024 14:43
@lippserd
Copy link
Member

@raviks789 Please write a summary about the issue in the PR description.

@lippserd lippserd force-pushed the fix/basket-restore-sync-job branch from 82c03a2 to 44a8bbb Compare November 7, 2024 09:39
@lippserd lippserd merged commit aaf5145 into master Nov 7, 2024
15 checks passed
@lippserd lippserd deleted the fix/basket-restore-sync-job branch November 7, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants