Fix that the dashboard loses selection, again #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
added
bug
sukhwinder33445
requested changes
Oct 10, 2023
There was a problem hiding this comment.
There is another small bug that the first click on comment/downtime in the detail view loads nothing and displays empty #col2:
- Select a host/service from the list that has at least one comment/downtime.
- Click on the comment/downtime in the detail view.
- There is an error in the console.
nilmerg
force-pushed
the
fix/dashboard-loses-selection-696
branch
from
34cfd30 to
48866e7
Compare
nilmerg
force-pushed
the
fix/dashboard-loses-selection-696
branch
from
48866e7 to
399f4a4
Compare
sukhwinder33445
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sukhwinder33445 I've changed the refresh suspension quite a bit, please re-test if the key navigation still behaves like you intended.
fixes #696