(Host|Service) Detail view: Introduce parents and children tab #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
introduce-parents-children-tab
branch
from
59dc8c9 to
74bb945
Compare
nilmerg
requested changes
Dec 9, 2024
sukhwinder33445
force-pushed
the
introduce-parents-children-tab
branch
2 times, most recently
from
c37ece0 to
9ab8072
Compare
|
Except for the error in the search bar while trying to apply filter in Parents/Children tabs, everything else seems to work as listed out in the issue. |
raviks789
reviewed
Dec 17, 2024
| protected function createTabs(): Tabs | ||
| { | ||
| $hasDependencyNode = DependencyNode::on($this->getDb()) | ||
| ->columns('1') |
There was a problem hiding this comment.
Suggested change
| ->columns('1') | |
| ->columns([new ipl\Sql\Expression('1')]) |
sukhwinder33445
force-pushed
the
introduce-parents-children-tab
branch
from
9ab8072 to
fb557c7
Compare
sukhwinder33445
force-pushed
the
introduce-parents-children-tab
branch
from
fb557c7 to
03a160d
Compare
- Otherwise the searchbar uses it as base filter and apply it on the query
- Set the outer tab as active. Previously, the inner tab was activated in the setTitleTab method, but the outer tab does not know about the state of inner tabs. So whenever sendMultipartUpdate() -> getActiveTab() was called, the retured value was always null.
sukhwinder33445
force-pushed
the
introduce-parents-children-tab
branch
from
03a160d to
2caf0ae
Compare
raviks789
reviewed
Jan 10, 2025
|
|
||
| $limitControl = $this->createLimitControl(); | ||
| $paginationControl = $this->createPaginationControl($nodesQuery); | ||
| $sortControl = $this->createSortControl( |
There was a problem hiding this comment.
IMO, it would be nice to have a default sort here. Or you could add getDefaultSort method to DependencyNode model. In which case you do not have to change the code every where createSortControl method is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
->onlyWithCustomVarSources(['host', 'service', 'hostgroup', 'servicegroup'])to the chain in
CompleteAction()ofHost/ServiceControllerto fix search suggestions inparents & childrentab.