Add config tab for Prometheus and multi-cluster support #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrauh01
force-pushed
the
prometheus-config
branch
2 times, most recently
from
f1f5bc1 to
aa99d38
Compare
jrauh01
changed the base branch from
auto-create-notifications-source
to
main
jrauh01
force-pushed
the
prometheus-config
branch
5 times, most recently
from
b7d2590 to
b0b211e
Compare
jrauh01
force-pushed
the
prometheus-config
branch
5 times, most recently
from
93f5449 to
c8a4321
Compare
lippserd
force-pushed
the
prometheus-config
branch
from
c8a4321 to
5af7fa1
Compare
lippserd
force-pushed
the
prometheus-config
branch
from
5af7fa1 to
11f9d5a
Compare
jrauh01
force-pushed
the
prometheus-config
branch
from
226a42e to
2c2c237
Compare
lippserd
force-pushed
the
prometheus-config
branch
from
b541113 to
49a466c
Compare
lippserd
changed the title
lippserd
force-pushed
the
prometheus-config
branch
from
49a466c to
cfd6cc4
Compare
lippserd
requested changes
Jan 14, 2025
| @@ -80,53 +70,69 @@ public function hasBeenSubmitted(): bool | |||
| }; | |||
|
|
|||
| $form = (new NotificationsConfigForm()) | |||
| ->setKConfig($kconfig) | |||
| ->populate(['cluster_uuid' => $this->getRequest()->get('id')]) | |||
There was a problem hiding this comment.
Please rename id to cluster_uuid and retrieve the default value from the session. This ensures that any changes a user makes to the displayed cluster are automatically reflected when working with the config. If the session is empty, we still populate null so that the form defaults to the first database entry in the cluster table.
| } | ||
|
|
||
| Notification::success( | ||
| $this->translate('New configuration has successfully been stored.') | ||
| ); | ||
|
|
||
| $this->redirectNow('__REFRESH__'); | ||
| $this->redirectNow(Url::fromPath('kubernetes/config/notifications', ['id' => $clusterUuid])); |
| public function prometheusAction() | ||
| { | ||
| $form = (new PrometheusConfigForm()) | ||
| ->populate(['cluster_uuid' => $this->getRequest()->get('id')]) |
There was a problem hiding this comment.
Please rename id to cluster_uuid and get the default value from the session.
| } | ||
|
|
||
| Notification::success($this->translate('New configuration has successfully been stored')); | ||
| $this->redirectNow(Url::fromPath('kubernetes/config/prometheus', ['id' => $clusterUuid])); |
There was a problem hiding this comment.
Rename id to cluster_uuid and add a newline before this line.
|
And please also reword your wip commit. |
jrauh01
force-pushed
the
prometheus-config
branch
from
cfd6cc4 to
416e890
Compare
jrauh01
force-pushed
the
prometheus-config
branch
from
416e890 to
0301350
Compare
lippserd
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new config tab for Prometheus. If the config is provided via yaml the data is locked and the form is disabled.