-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NDTensors] Introduce LabelledNumbers
and GradedAxesNext
#1351
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1351 +/- ##
===========================================
- Coverage 84.40% 53.78% -30.62%
===========================================
Files 100 99 -1
Lines 8581 8528 -53
===========================================
- Hits 7243 4587 -2656
- Misses 1338 3941 +2603 ☔ View full report in Codecov by Sentry. |
LabelledNumbers
and GradedAxesNext
LabelledNumbers
and GradedAxesNext
@ogauthe this doesn't have all of the features of |
LabelledNumbers
and GradedAxesNext
LabelledNumbers
and GradedAxesNext
Great. I paused my work on |
This is a rewrite and redesign of
GradedAxes
, for now calledGradedAxesNext
but the goal will be to removeGradedAxes
and replace it with the code inGradedAxesNext
(either here or in a follow-up PR). The goal is to make it easier to implement slicing operations of graded unit ranges which preserve the sector labels (which is needed for finishing #1332), which I have found is a bit more cumbersome than I think is necessary with the currentGradedAxes
design.@emstoudenmire @ogauthe