Skip to content

Commit

Permalink
Fix corner case for diaglength
Browse files Browse the repository at this point in the history
  • Loading branch information
mtfishman committed Nov 30, 2023
1 parent ba43de9 commit d5459a8
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
2 changes: 2 additions & 0 deletions NDTensors/src/lib/DiagonalArrays/src/diaginterface.jl
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
using Compat: allequal

diaglength(a::AbstractArray{<:Any,0}) = 1

function diaglength(a::AbstractArray)
return minimum(size(a))
end
Expand Down
7 changes: 7 additions & 0 deletions NDTensors/src/lib/DiagonalArrays/test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,12 @@ using NDTensors.DiagonalArrays: DiagonalArrays
),
) isa Any
end
@testset "Basics" begin
using NDTensors.DiagonalArrays: diaglength
a = fill(1.0, 2, 3)
@test diaglength(a) == 2
a = fill(1.0)
@test diaglength(a) == 1
end
end
end

0 comments on commit d5459a8

Please sign in to comment.