Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing functionality like tagging and priming #4

Merged
merged 9 commits into from
Jan 16, 2025

Conversation

mtfishman
Copy link
Member

Add missing functionality like tagging and priming, focusing on functionality needed for ITensor/ITensors.jl#1611, ITensor/ITensorMPS.jl#108.

@mtfishman mtfishman marked this pull request as draft January 12, 2025 00:50
@mtfishman mtfishman changed the title Add missing functionality like tagging and priming [WIP] Add missing functionality like tagging and priming Jan 12, 2025
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 28.40909% with 63 lines in your changes missing coverage. Please review.

Project coverage is 46.45%. Comparing base (0fd1ea2) to head (ac1dbfe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ITensorBase.jl 33.78% 49 Missing ⚠️
src/quirks.jl 0.00% 14 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0fd1ea2) and HEAD (ac1dbfe). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0fd1ea2) HEAD (ac1dbfe)
docs 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #4       +/-   ##
===========================================
- Coverage   87.50%   46.45%   -41.05%     
===========================================
  Files           1        2        +1     
  Lines          40      127       +87     
===========================================
+ Hits           35       59       +24     
- Misses          5       68       +63     
Flag Coverage Δ
docs 45.23% <28.40%> (-39.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman marked this pull request as ready for review January 16, 2025 23:37
@mtfishman mtfishman changed the title [WIP] Add missing functionality like tagging and priming Add missing functionality like tagging and priming Jan 16, 2025
@mtfishman mtfishman merged commit 354c56d into main Jan 16, 2025
10 checks passed
@mtfishman mtfishman deleted the tagging_priming branch January 16, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant