-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Expose wallet_id
to computational and dynamic services via env vars upon request
#7125
🎨 Expose wallet_id
to computational and dynamic services via env vars upon request
#7125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7125 +/- ##
===========================================
- Coverage 87.53% 70.59% -16.95%
===========================================
Files 1635 637 -998
Lines 63872 30924 -32948
Branches 2053 262 -1791
===========================================
- Hits 55913 21832 -34081
- Misses 7622 9032 +1410
+ Partials 337 60 -277
Continue to review full report in Codecov by Sentry.
|
services/director-v2/src/simcore_service_director_v2/modules/osparc_variables/substitutions.py
Outdated
Show resolved
Hide resolved
services/director-v2/tests/unit/test_modules_osparc_variables.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
services/director-v2/src/simcore_service_director_v2/modules/osparc_variables/substitutions.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
wallet_id
to computational and dynamic services via env vars upon request
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 1433e6e |
Quality Gate passedIssues Measures |
What do these changes do?
It is now possible to request the
wallet_id
viaOSPARC_VARIABLE_WALLET_ID
inside a service.Related issue/s
How to test
Dev-ops checklist