Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Frontend] New + Button #7089

Merged
merged 66 commits into from
Jan 29, 2025
Merged

✨ [Frontend] New + Button #7089

merged 66 commits into from
Jan 29, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 24, 2025 •
edited
Loading

What do these changes do?

  • New Plus button, populated by the existing new_studies.json
    • Create Empty study
    • Start from Template
    • Start from Service
      • Access service details from info button
    • Support all features used in TIP's New Plans window
  • Make New Plus button enable/disable (disabled in TIP for now)
  • Remove nav bar buttons
    • Tutorials: move to the left Menu
    • Services: move to the left Menu
  • Update tests

S4L
s4l

S4L.lite
s4llite

oSparc
osparc

TIP.lite (@calys, we won't switch to this new-plus-button yet)
TIP-Lite

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Jan 24, 2025
@odeimaiz odeimaiz added this to the Singularity milestone Jan 24, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jan 24, 2025
@odeimaiz odeimaiz marked this pull request as ready for review January 29, 2025 10:18
matusdrobuliak66
matusdrobuliak66 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! UI input: I would make the dividers for sections inside of plus button more visible/differentiable.
image

@odeimaiz
Copy link
Member Author

odeimaiz commented Jan 29, 2025 •
edited
Loading

Thanks! UI input: I would make the dividers for sections inside of plus button more visible/differentiable.

Increased the contrast of the category's header text and added some extra margin between categories.

image

ignapas
ignapas approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@GitHK GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label Jan 29, 2025
@GitHK
Copy link
Contributor

GitHK commented Jan 29, 2025

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 29, 2025 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 1713021

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mergify mergify bot merged commit 1713021 into ITISFoundation:master Jan 29, 2025
92 of 95 checks passed
@odeimaiz odeimaiz deleted the feature/new-plus-button branch January 29, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@calys calys Awaiting requested review from calys

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@GitHK GitHK Awaiting requested review from GitHK

@mguidon mguidon Awaiting requested review from mguidon

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels
🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Singularity
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @GitHK @ignapas @pcrespov @matusdrobuliak66