Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [Frontend] Search users as they type #7037

Merged
merged 11 commits into from
Jan 15, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 14, 2025

What do these changes do?

After seeing that the users:search call is not an expensive one, in this PR the search-users-as-you-type was implemented.

SearchAsType

Related issue/s

How to test

Dev-ops checklist

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@odeimaiz odeimaiz self-assigned this Jan 14, 2025
@odeimaiz odeimaiz added this to the Singularity milestone Jan 14, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jan 14, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Search users as I type 🎨 [Frontend] Search users as they type Jan 14, 2025
@odeimaiz odeimaiz marked this pull request as ready for review January 14, 2025 14:49
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We should improve the search with Fuzzy package Postgres plugin, as was proposed by Pedro.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.
Did you check if I delete? i.e. start typing 3 ... then delete one ...

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@odeimaiz odeimaiz merged commit a63e747 into ITISFoundation:master Jan 15, 2025
55 checks passed
@odeimaiz odeimaiz deleted the enh/search-users-as-i-type branch January 15, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants