Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 [Frontend] Trash Enhancements #7029

Merged
merged 9 commits into from
Jan 14, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 13, 2025

What do these changes do?

requested by @calys

  • Rename: Trash -> Bin
  • Rename: Trash/Move to Trash -> Move to Bin
  • Rename: Delete -> Delete permanently
  • Bin's icon: Do not color it, slightly change the icon
  • Hide Empty Bin button until the action gets implemented
  • Fix: infinite get trashed page

BinIsTheNewTrash

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz marked this pull request as ready for review January 13, 2025 13:39
@odeimaiz odeimaiz requested a review from calys January 13, 2025 13:40
@odeimaiz odeimaiz self-assigned this Jan 13, 2025
@odeimaiz odeimaiz added this to the Event Horizon milestone Jan 13, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Jan 13, 2025
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) January 13, 2025 13:45
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@calys
Copy link

calys commented Jan 13, 2025

I like it a lot, thanks Odei!
Maybe I would consider "downgrading" the danger level of the "Move to Bin" button (from yellow to purple) and the "Empty Bin" button (from red to purple). The only one in red would be the "Delete Permanently" button in the confirmation pop-up.

@odeimaiz
Copy link
Member Author

odeimaiz commented Jan 13, 2025

Maybe I would consider "downgrading" the danger level of the "Move to Bin" button (from yellow to purple) and the "Empty Bin" button (from red to purple). The only one in red would be the "Delete Permanently" button in the confirmation pop-up.

Empty Bin means Delete Permanently all content in the Bin, so I would keep it red (danger action). Btw, since this action is not implemented yet, I'll hide it for now.

Regarding Move to Bin, I wouldn't make it purple (create/positive action), but I could make it gray (neutral action) if you really want to.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice !

@odeimaiz odeimaiz merged commit f0212cb into ITISFoundation:master Jan 14, 2025
55 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants