✨ Adding director-v0 client to dynamic-scheduler

[GitHK]

What do these changes do?

Adding interface for director-v0 inside dynamic-scheduler. Only the functionality used by the dynamic backend was extracted from director-v2.

Related issue/s

• dynamic scheduler: extract scheduling logic and move it away from director-v2 #5632
• closes requirement: add director-v0 client to dynamic-scheduler #7002

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 14 lines in your changes missing coverage. Please review.

Project coverage is 85.24%. Comparing base (a63e747) to head (c5e9951).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7001      +/-   ##
==========================================
- Coverage   86.82%   85.24%   -1.59%     
==========================================
  Files        1651     1518     -133     
  Lines       64839    61731    -3108     
  Branches     2043     1742     -301     
==========================================
- Hits        56299    52625    -3674     
- Misses       8205     8824     +619     
+ Partials      335      282      -53     

Flag	Coverage Δ
integrationtests	64.17% <100.00%> (+0.71%)	⬆️
unittests	84.90% <85.71%> (-0.07%)	⬇️

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	91.56% <ø> (-0.03%)	⬇️
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	70.02% <ø> (ø)
pkg_service_library	73.88% <ø> (ø)
pkg_settings_library	90.49% <84.61%> (-0.12%)	⬇️
pkg_simcore_sdk	85.38% <ø> (ø)
agent	96.45% <ø> (ø)
api_server	90.54% <ø> (ø)
autoscaling	96.09% <ø> (ø)
catalog	90.66% <ø> (ø)
clusters_keeper	99.24% <ø> (ø)
dask_sidecar	91.26% <ø> (ø)
datcore_adapter	93.18% <ø> (ø)
director	76.42% <ø> (ø)
director_v2	91.29% <100.00%> (-0.03%)	⬇️
dynamic_scheduler	96.36% <85.18%> (-0.84%)	⬇️
dynamic_sidecar	89.75% <ø> (ø)
efs_guardian	90.46% <ø> (ø)
invitations	93.44% <ø> (ø)
osparc_gateway_server	∅ <ø> (∅)
payments	92.66% <ø> (ø)
resource_usage_tracker	89.57% <ø> (+0.29%)	⬆️
storage	89.57% <ø> (ø)
webclient	∅ <ø> (∅)
webserver	79.27% <ø> (-4.45%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a63e747...c5e9951. Read the comment docs.

[sanderegg]

I am not sure I understand the approach here.

The director V0 dynamic services facilities were only to be used via the director-v2, and now you are moving all this away.
Even if the director-v0 was upgraded to fastapi, we still want to deprecate the legacy services part. with what you are doing here, you are opening the door again unless I am missing something.

Also, why do you need to access the service labels via the dv-0? these are exposed by the catalog, which also adds up overrides, etc etc on top. This is all lost if you go straight for dv-0.

Let's maybe discuss the use-case. Thanks!

[sanderegg]

so you will remove the dv-0 forwarding calls from the dv-2?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud