Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrades deprecated pydantic calls repo-wide #6864

Merged
merged 8 commits into from
Nov 29, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 28, 2024

What do these changes do?

Based on the PydanticDeprecatedSince20 warnings shown in the model-library tests, I upgrades repo-wise some pydantic calls.

Removed some outdated docs 📝 and makefile recipes 🔨

Related issue/s

  • Maintenance

How to test

Dev-ops checklist

None

@pcrespov pcrespov added this to the Event Horizon milestone Nov 28, 2024
@pcrespov pcrespov self-assigned this Nov 28, 2024
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Nov 28, 2024
@pcrespov pcrespov marked this pull request as ready for review November 28, 2024 18:39
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base (277cf70) to head (484de28).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6864      +/-   ##
==========================================
- Coverage   88.39%   88.37%   -0.03%     
==========================================
  Files        1550     1550              
  Lines       61768    61769       +1     
  Branches     2110     2110              
==========================================
- Hits        54602    54590      -12     
- Misses       6835     6848      +13     
  Partials      331      331              
Flag Coverage Δ
integrationtests 64.75% <ø> (-0.13%) ⬇️
unittests 86.28% <100.00%> (-0.06%) ⬇️
Components Coverage Δ
api 78.42% <ø> (ø)
pkg_aws_library 93.28% <ø> (ø)
pkg_dask_task_models_library 96.57% <ø> (ø)
pkg_models_library 91.22% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 87.52% <ø> (ø)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library 75.91% <ø> (ø)
pkg_settings_library 90.62% <ø> (ø)
pkg_simcore_sdk 85.36% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.02% <ø> (-0.23%) ⬇️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server 85.49% <ø> (ø)
payments 92.77% <ø> (ø)
resource_usage_tracker 90.79% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.67% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 277cf70...484de28. Read the comment docs.

@pcrespov pcrespov enabled auto-merge (squash) November 28, 2024 19:44
@pcrespov pcrespov disabled auto-merge November 28, 2024 19:44
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
please have a look at my comment regarding json_dumps.

@pcrespov pcrespov enabled auto-merge (squash) November 29, 2024 10:58
@pcrespov pcrespov merged commit abcf347 into ITISFoundation:master Nov 29, 2024
89 of 90 checks passed
@pcrespov pcrespov deleted the mai/pydantic-upgrades branch November 29, 2024 12:18
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants