🎨 Add payment headers to start job

[bisgaard-itis]

What do these changes do?

• Add the possibility to add a pricing-plan-id and pricing-unit-id when starting a job via the api server. This is done by passing headers x-pricing-plan and x-pricing-unit.
• These are not required to start a job. Hence, I am relying on the assumption that, if a pricing plan and unit are required for a job to run, then this will be checked elsewhere and the job/project will fail if these are not passed.
• I also refactored services/api-server/src/simcore_service_api_server/api/routes/solvers_jobs.py to make the automatic code checkers happy

Related issue/s

• resolves API: access to wallets/payment for job submission #4768

How to test

I added unit tests to the API server unittest suite. So they will run automatically in the github workflow

DevOps Checklist

[bisgaard-itis]

requesting a review from you @mguidon so you can see the mechanism you will need to use from S4L and have a chance to make comments before it goes in.

[bisgaard-itis]

@pcrespov if you have a look at this, maybe think about if something needs to be done concerning products in this PR. I don't yet understand how that will fit into the picture...

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@c751b1d). Click here to learn what that means.
The diff coverage is 69.3%.

❗ Current head 9ebb7c0 differs from pull request most recent head dad8043. Consider uploading reports for the commit dad8043 to get more accurate results

@@           Coverage Diff            @@
##             master   #4892   +/-   ##
========================================
  Coverage          ?   66.6%           
========================================
  Files             ?     576           
  Lines             ?   28323           
  Branches          ?     195           
========================================
  Hits              ?   18869           
  Misses            ?    9405           
  Partials          ?      49           

Flag	Coverage Δ
integrationtests	65.1% <ø> (?)
unittests	82.1% <69.3%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...-server/src/simcore_service_api_server/api/root.py	100.0% <100.0%> (ø)
...core_service_api_server/api/routes/solvers_jobs.py	85.5% <100.0%> (ø)
.../simcore_service_api_server/models/schemas/jobs.py	96.1% <100.0%> (ø)
...c/simcore_service_api_server/services/webserver.py	89.7% <100.0%> (ø)
...ore_service_api_server/utils/http_calls_capture.py	87.5% <50.0%> (ø)
...rc/simcore_service_api_server/utils/client_base.py	86.4% <50.0%> (ø)
..._api_server/utils/http_calls_capture_processing.py	78.9% <25.0%> (ø)
...vice_api_server/api/routes/solvers_jobs_getters.py	79.6% <79.6%> (ø)
...imcore_service_api_server/utils/client_base_dev.py	0.0% <0.0%> (ø)

[pcrespov]

Great job! I added some suggestions!

[pcrespov]

@pcrespov if you have a look at this, maybe think about if something needs to be done concerning products in this PR. I don't yet understand how that will fit into the picture...

@bisgaard-itis see my comments and the issue I refer above.The permissions to access those price lists are attached to the project. The webserver is the responsible for access-rights. When the api-server knows about the product, the request to the webserver should resolve permissions to those.

[bisgaard-itis]

@pcrespov if you have a look at this, maybe think about if something needs to be done concerning products in this PR. I don't yet understand how that will fit into the picture...

@bisgaard-itis see my comments and the issue I refer above.The permissions to access those price lists are attached to the project. The webserver is the responsible for access-rights. When the api-server knows about the product, the request to the webserver should resolve permissions to those.

Sounds good. Thanks

[pcrespov]

please solve as well the 3 code smells that sonarcloud is spotting. thx

[bisgaard-itis]

@mrnicegyu11 @YuryHrytsuk could I get one of you to take a look at this. I think I need one of your approvals. Probably because I changed an environment variable. This is only related to the dev environment and only for the api server

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codeclimate]

Code Climate has analyzed commit dad8043 and detected 0 issues on this pull request.

View more on Code Climate.