Is2911/fix delete project

[pcrespov]

What do these changes do?

New project deletion takes the following steps:

1. marks project row as invisible (next PR will mark it as trashed)
2. stops dynamic services
3. stops computational services
4. calls to delete data (next PR will mark it as trashed)
5. deletes project (row database).

The key difference is that now the project is deleted last which keeps all the access-rights information necessary to perform the deletion in storage.

NEXT: A follow up to this case will be a trash for projects ITISFoundation/osparc-issues#468. There we will also extend delete workflows and integration tests.

Misc

• ♻️ cleanup test_garbage_collector as well as some logs in gc plugin.
• ♻️ split projects_handler since >500 lines
• add storage info on show endpoint makefile recipe
• fixed deprecation warning:

 DeprecationWarning: The 'asyncio_mode' is 'legacy', switching to 'auto' for the sake of pytest-aiohttp backward compatibility. Please explicitly use 'asyncio_mode=strict' or 'asyncio_mode=auto' in pytest configuration file.
    config.issue_config_time_warning(LEGACY_MODE, stacklevel=2)

Related issue/s

• Fixes Entries in file_meta_data table not deleted when project is deleted #2911
• Fixes storage does not delete files from project #2754
• closes PR 🐛♻️ Deleting a project now removes its files #2777

How to test

Manual testing

NOTE: will provide an internal entrypoint for testing on Friday

• Manual test workflow described in Entries in file_meta_data table not deleted when project is deleted #2911
• Manual test workflow described in storage does not delete files from project #2754
• Manual test with @odeimaiz
  • create project 1, upload file, close
  • create new project 2, add file-picker and select previous file, close file
  • delete project 2 -> should not delete upload file because it is in project 1

Automatic CI

pytest  tests/**/test_*delete*.py

will run

<Module tests/unit/with_dbs/02/test_projects_delete.py>
  <Function test_delete_project[UserRole.ANONYMOUS-expected0]>
  <Function test_delete_project[UserRole.GUEST-expected1]>
  <Function test_delete_project[UserRole.USER-expected2]>
  <Function test_delete_project[UserRole.TESTER-expected3]>
  <Function test_delete_multiple_opened_project_forbidden[UserRole.ANONYMOUS-HTTPUnauthorized-HTTPUnauthorized]>
  <Function test_delete_multiple_opened_project_forbidden[UserRole.GUEST-HTTPOk-HTTPForbidden]>
  <Function test_delete_multiple_opened_project_forbidden[UserRole.USER-HTTPOk-HTTPForbidden]>
  <Function test_delete_multiple_opened_project_forbidden[UserRole.TESTER-HTTPOk-HTTPForbidden]>

[codecov]

Codecov Report

Merging #2967 (cf01f53) into master (68a981d) will increase coverage by 0.0%.
The diff coverage is 86.1%.

@@          Coverage Diff           @@
##           master   #2967   +/-   ##
======================================
  Coverage    79.6%   79.6%           
======================================
  Files         681     683    +2     
  Lines       28417   28504   +87     
  Branches     3661    3671   +10     
======================================
+ Hits        22622   22692   +70     
- Misses       5027    5043   +16     
- Partials      768     769    +1     

Flag	Coverage Δ
integrationtests	65.7% <71.1%> (+<0.1%)	⬆️
unittests	75.3% <84.5%> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...es/storage/src/simcore_service_storage/handlers.py	71.3% <50.0%> (ø)
...vice_webserver/exporter/formatters/formatter_v1.py	78.8% <66.6%> (+0.1%)	⬆️
...rvice_webserver/projects/projects_handlers_crud.py	82.8% <82.8%> (ø)
.../src/simcore_service_webserver/projects/_delete.py	85.1% <85.1%> (ø)
...imcore_service_webserver/garbage_collector_core.py	68.2% <91.3%> (+1.6%)	⬆️
...imcore_service_webserver/garbage_collector_task.py	100.0% <100.0%> (+5.1%)	⬆️
...mcore_service_webserver/garbage_collector_utils.py	79.4% <100.0%> (+1.3%)	⬆️
...es/web/server/src/simcore_service_webserver/log.py	66.6% <100.0%> (-2.6%)	⬇️
...imcore_service_webserver/meta_modeling_projects.py	82.0% <100.0%> (ø)
...r/src/simcore_service_webserver/projects/plugin.py	86.6% <100.0%> (ø)
... and 15 more

[mrnicegyu11]

Thanks a lot for this contribution! Nice! :--)

[GitHK]

👍 Thanks for this.

[odeimaiz]

Saw it working 👌

[KZzizzle]

thanks for the putting this together - definitely much needed!