[chore] #5 Log -> Timber로 대체

IN-SOPT-ANDROID · Dec 26, 2022 · d17fb32 · d17fb32
1 parent e460da4
commit d17fb32
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 9 deletions.
diff --git a/app/src/main/java/org/sopt/sample/presentation/home/HomeViewModel.kt b/app/src/main/java/org/sopt/sample/presentation/home/HomeViewModel.kt
@@ -1,6 +1,5 @@
 package org.sopt.sample.presentation.home
 
-import android.util.Log
 import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
 import androidx.lifecycle.ViewModel
@@ -10,6 +9,7 @@ import org.sopt.sample.util.state.UiState
 import retrofit2.Call
 import retrofit2.Callback
 import retrofit2.Response
+import timber.log.Timber
 
 class HomeViewModel : ViewModel() {
 
@@ -38,7 +38,7 @@ class HomeViewModel : ViewModel() {
 
             override fun onFailure(call: Call<ResponseUser>, t: Throwable) {
                 _userResult.value = UiState.Error(t.toString())
-                Log.e("Gallery FAIL", "mes : " + t.message)
+                Timber.tag("Gallery FAIL").e("mes : " + t.message)
             }
 
         })

diff --git a/app/src/main/java/org/sopt/sample/presentation/login/LoginActivity.kt b/app/src/main/java/org/sopt/sample/presentation/login/LoginActivity.kt
@@ -5,13 +5,15 @@ import android.os.Bundle
 import androidx.activity.result.ActivityResultLauncher
 import androidx.activity.result.contract.ActivityResultContracts
 import androidx.activity.viewModels
+import org.sopt.sample.BuildConfig
 import org.sopt.sample.R
 import org.sopt.sample.base.BindingActivity
 import org.sopt.sample.databinding.ActivityLoginBinding
 import org.sopt.sample.presentation.home.HomeActivity
 import org.sopt.sample.presentation.signup.SignUpActivity
 import org.sopt.sample.util.showSnackbar
 import org.sopt.sample.util.state.NetworkState
+import timber.log.Timber
 
 class LoginActivity : BindingActivity<ActivityLoginBinding>(R.layout.activity_login) {
     private lateinit var resultLauncher: ActivityResultLauncher<Intent>
@@ -26,6 +28,9 @@ class LoginActivity : BindingActivity<ActivityLoginBinding>(R.layout.activity_lo
                 binding.root.showSnackbar(getString(R.string.signup_finish), true)
             }
         }
+        if(BuildConfig.DEBUG){
+            Timber.plant(Timber.DebugTree())
+        }
         addListeners()
         addObservers()
     }

diff --git a/app/src/main/java/org/sopt/sample/presentation/login/LoginViewModel.kt b/app/src/main/java/org/sopt/sample/presentation/login/LoginViewModel.kt
@@ -1,6 +1,5 @@
 package org.sopt.sample.presentation.login
 
-import android.util.Log
 import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
 import androidx.lifecycle.ViewModel
@@ -11,6 +10,7 @@ import org.sopt.sample.util.state.NetworkState
 import retrofit2.Call
 import retrofit2.Callback
 import retrofit2.Response
+import timber.log.Timber
 
 class LoginViewModel : ViewModel() {
 
@@ -41,7 +41,7 @@ class LoginViewModel : ViewModel() {
 
             override fun onFailure(call: Call<ResponseLogin>, t: Throwable) {
                 _loginResult.value = NetworkState.Error(t)
-                Log.e("SIGN IN FAIL", "mes : " + t.message)
+                Timber.tag("SIGN IN FAIL").e("mes : " + t.message)
             }
         })
     }

diff --git a/app/src/main/java/org/sopt/sample/presentation/signup/SignUpActivity.kt b/app/src/main/java/org/sopt/sample/presentation/signup/SignUpActivity.kt
@@ -2,14 +2,14 @@ package org.sopt.sample.presentation.signup
 
 import android.content.Intent
 import android.os.Bundle
-import android.util.Log
 import androidx.activity.viewModels
 import org.sopt.sample.R
 import org.sopt.sample.base.BindingActivity
 import org.sopt.sample.databinding.ActivitySignUpBinding
 import org.sopt.sample.presentation.login.LoginActivity
 import org.sopt.sample.util.showSnackbar
 import org.sopt.sample.util.state.NetworkState
+import timber.log.Timber
 
 class SignUpActivity : BindingActivity<ActivitySignUpBinding>(R.layout.activity_sign_up) {
 
@@ -35,8 +35,8 @@ class SignUpActivity : BindingActivity<ActivitySignUpBinding>(R.layout.activity_
 
     private fun addObservers() {
         viewModel.emailFlag.observe(this) {
-            Log.i("emailFlag", it.toString())
-            Log.i("emailCheck", binding.layoutEtEmail.isErrorEnabled.toString())
+            Timber.i("emailFlag : $it")
+            Timber.i("emailCheck : " + binding.layoutEtEmail.isErrorEnabled.toString())
             if (it) {//이메일 양식이 맞을 때
                 binding.layoutEtEmail.error = null
                 binding.layoutEtEmail.isErrorEnabled = false

diff --git a/app/src/main/java/org/sopt/sample/presentation/signup/SignUpViewModel.kt b/app/src/main/java/org/sopt/sample/presentation/signup/SignUpViewModel.kt
@@ -1,6 +1,5 @@
 package org.sopt.sample.presentation.signup
 
-import android.util.Log
 import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
 import androidx.lifecycle.Transformations
@@ -12,6 +11,7 @@ import org.sopt.sample.util.state.NetworkState
 import retrofit2.Call
 import retrofit2.Callback
 import retrofit2.Response
+import timber.log.Timber
 
 class SignUpViewModel : ViewModel() {
     private val _signUpResult = MutableLiveData<NetworkState>()
@@ -50,7 +50,7 @@ class SignUpViewModel : ViewModel() {
 
             override fun onFailure(call: Call<ResponseSignup>, t: Throwable) {
                 _signUpResult.value = NetworkState.Error(t)
-                Log.e("SIGNUP FAIL", "mes : " + t.message)
+                Timber.tag("SIGNUP FAIL").e("mes : " + t.message)
 
             }
         })