Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

215 notification about auth transitioning #216

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

longshuicy
Copy link
Member

  • Created new custom component to handle warning; can reuse for other warnings in the future
  • Add warning to redux so in the future can be reused for system level warning across the app
image

@longshuicy longshuicy linked an issue Aug 13, 2024 that may be closed by this pull request
@navarroc
Copy link
Member

navarroc commented Aug 14, 2024

How hard would it be to make a temporary variable (boolean) that we put in local cache that indicates the user closed the warning message and to not show again unless they clear cache? My only concern is that anytime a user navigates to the home page they will see the message (e.g. if you go from the data viewer back to home, it will show again).

Otherwise this looks good.

@navarroc
Copy link
Member

Another option would be to hide if logged in maybe?

@longshuicy
Copy link
Member Author

How hard would it be to make a temporary variable (boolean) that we put in local cache that indicates the user closed the warning message and to not show again unless they clear cache? My only concern is that anytime a user navigates to the home page they will see the message (e.g. if you go from the data viewer back to home, it will show again).

Otherwise this looks good.

Like we discussed in hackathon, we would like to address that in the next release.

@longshuicy longshuicy merged commit ff591c5 into develop Aug 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification about auth transitioning
2 participants