Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

206 restrict a user in a particular user group from performing or accessing anything #207

Merged
merged 15 commits into from
Aug 9, 2024
Merged

206 restrict a user in a particular user group from performing or accessing anything #207

merged 15 commits into from
Aug 9, 2024

Conversation

longshuicy
Copy link
Member

@longshuicy longshuicy commented Jul 1, 2024 •
edited
Loading

Ready to be reviewed:

This PR catches all the 403 error (which is the backend response when a user doesn't belong to any group) and redirect to a forbidden page; forbids user from any actions.

To Test:

  1. npm run start:dev
  2. Login with username: testuser2, password: {contact developer} --> this is a special user that doesn't belong to any group
  3. Try to go to any viewers and profile page would direct to the forbidden page
  4. Landing page stays the same
image

@longshuicy longshuicy linked an issue Jul 1, 2024 that may be closed by this pull request
Restrict a user in a particular user group from performing or accessing anything #206
Closed
@longshuicy longshuicy marked this pull request as ready for review July 1, 2024 19:37
@longshuicy longshuicy changed the title WIP: 206 restrict a user in a particular user group from performing or accessing anything 206 restrict a user in a particular user group from performing or accessing anything Jul 1, 2024
@longshuicy longshuicy self-assigned this Jul 1, 2024
@longshuicy longshuicy changed the title 206 restrict a user in a particular user group from performing or accessing anything WIP - 206 restrict a user in a particular user group from performing or accessing anything Jul 24, 2024
@longshuicy longshuicy changed the title WIP - 206 restrict a user in a particular user group from performing or accessing anything 206 restrict a user in a particular user group from performing or accessing anything Jul 25, 2024
@Rashmil-1999
Copy link
Collaborator

When I try to go to Jupyterhub, it still gives me this blank screen error.

@longshuicy
Copy link
Member Author

When I try to go to Jupyterhub, it still gives me this blank screen error.

I deployed this to dev. On dev, when you go to jupyterhub with a unauthorized user, the jupyter hub gives below error
image

But this part is related to Jupyter's authenticator; frontend don't have much to do with it.

@Rashmil-1999
Copy link
Collaborator

Ahh I see... Let me review it ... :)

@longshuicy longshuicy requested a review from navarroc August 7, 2024 20:35
Rashmil-1999
Rashmil-1999 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@Rashmil-1999 Rashmil-1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@longshuicy longshuicy merged commit 3d843bb into develop Aug 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rashmil-1999 Rashmil-1999 Rashmil-1999 approved these changes

@navarroc navarroc navarroc approved these changes

@ywkim312 ywkim312 Awaiting requested review from ywkim312

@ylyangtw ylyangtw Awaiting requested review from ylyangtw

Assignees

@longshuicy longshuicy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restrict a user in a particular user group from performing or accessing anything
3 participants
@longshuicy @Rashmil-1999 @navarroc