170 Remodel INCORE home page #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update NewHomePage.jsx Styling changes Collapsible version block Intro block Replaced old homepage
longshuicy
requested changes
Jan 17, 2024
There was a problem hiding this comment.
- - Could you add a changelog entry?
- - Once expand I still see the logo overlapping the topbar. Could you check if you pushed your fix to that?
-
- - Could you unify the font? Either pick the same as the description; or the same as the instruction.
- - Could you double check all the buttons/links leads to a new tab so user can still stay on the same page
- Since there are less content on the page now maybe we can increase the fontsize? thoughts?
…CORE/incore-ui into 170-remodel-incore-home-page
Need to double check all links go to a new tab
longshuicy
approved these changes
Feb 1, 2024
Vismayak
added a commit
that referenced
this pull request
Feb 6, 2024
170 Remodel INCORE home page (#173) * MD didnt work, starting homepage usiong old themes Update NewHomePage.jsx Styling changes Collapsible version block Intro block Replaced old homepage * New homepage changes * Bug changes and adding to link * Implemented suggestions and created changelog Need to double check all links go to a new tab * Update HomePage.jsx Redux implementation (Logout done) Hella promising so far Redux needs to be set for tokens and stuff Login and logout seems to be working Cookies were set but a lot of redirects are happening I think Login is working but it goes off on refresh I think the damn login and logout is finally working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you guys have any input on how I can make the page look better? :)