Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

160 add links to slack channel and mailing list #161

Merged
merged 8 commits into from
Nov 2, 2023
Merged

160 add links to slack channel and mailing list #161

merged 8 commits into from
Nov 2, 2023

Conversation

longshuicy
Copy link
Member

@longshuicy longshuicy commented Nov 2, 2023 •
edited
Loading

image image

@longshuicy longshuicy linked an issue Nov 2, 2023 that may be closed by this pull request
Add links to slack channel and mailing list #160
Closed
@navarroc
Copy link
Member

navarroc commented Nov 2, 2023

I would maybe change inquiries to questions. Otherwise I think it looks good.

ylyangtw
ylyangtw approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@ylyangtw ylyangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI looks nice. Changes look no problem

@longshuicy
Copy link
Member Author

I would maybe change inquiries to questions. Otherwise I think it looks good.

done

@navarroc
Copy link
Member

navarroc commented Nov 2, 2023

Oh, one other thing, testbed channels are all locked. We might need to remove that text.

@longshuicy
Copy link
Member Author

Oh, one other thing, testbed channels are all locked. We might need to remove that text.

updated

@navarroc
Copy link
Member

navarroc commented Nov 2, 2023

The slack logo doesn't render for me on my machine. Do you see it @ylyangtw ? Also, I'm not sure what's better, to link to the shortened URL or the long URL. In the docs, I used the long url. I'm not sure how users will feel about clicking on a shortened URL. Thoughts from others?

@longshuicy longshuicy merged commit 3ac6305 into develop Nov 2, 2023
3 checks passed
@navarroc navarroc deleted the 160-add-links-to-slack-channel-and-mailing-list branch June 12, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ylyangtw ylyangtw ylyangtw approved these changes

@navarroc navarroc navarroc approved these changes

@ywkim312 ywkim312 Awaiting requested review from ywkim312

@Rashmil-1999 Rashmil-1999 Awaiting requested review from Rashmil-1999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add links to slack channel and mailing list
3 participants
@longshuicy @navarroc @ylyangtw