Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uploading to geoserver identical for both shapefile and geopackage #266

Conversation

ywkim312
Copy link
Member

@ywkim312 ywkim312 commented Jan 30, 2024

Please test with the attached zip file.
After unzip it, you will see one geopackage file (guid_test.gpkg) and others that are shapefile component (epn_guid.shp)

data.zip

Test posting both dataset

Testing GeoPackage

  1. create a dataset with
    {"format": "geopackage", "title": "test-delete", "description": "delete me", "dataType": "incore:addressPoints"}
    please ignore dataType, this is just a test
  2. attach geopackage file to the dataset created in step 1
  3. if attach process is successful, the PR is good
  4. remove the dataset created in step 1

Testing Shapefile

  1. create a dataset with
    {"format": "shapefile", "title": "test-delete", "description": "delete me", "dataType": "incore:addressPoints"}
    please ignore dataType, this is just a test
  2. attach shpefile components (.shp, .dbf, .shx, .prj) to the dataset created in step 1
  3. if attach process is successful, the PR is good
  4. remove the dataset created in step 1

Copy link
Contributor

@ylyangtw ylyangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uploaded both shapefile and geopackage successfully. change look good

@navarroc
Copy link
Member

navarroc commented Feb 1, 2024

Can you add a copyright header to the GeoserverRestApi class?

@ywkim312
Copy link
Member Author

ywkim312 commented Feb 1, 2024

Can you add a copyright header to the GeoserverRestApi class?

Added

@navarroc
Copy link
Member

navarroc commented Feb 1, 2024

How do I test this? Can I test it on my local or do I need to use port forwarding to test on dev?

@ywkim312
Copy link
Member Author

ywkim312 commented Feb 1, 2024

How do I test this? Can I test it on my local or do I need to use port forwarding to test on dev?

You can test it in local. Maybe let me deploy this to dev now and will let you know

@navarroc
Copy link
Member

navarroc commented Feb 1, 2024

How do I test this? Can I test it on my local or do I need to use port forwarding to test on dev?

You can test it in local. Maybe let me deploy this to dev now and will let you know

I was able to test on my local. No need to deploy on dev.

@navarroc
Copy link
Member

navarroc commented Feb 1, 2024

Can you remove the system.out print statements in GeoserverRestAPI?

@ywkim312
Copy link
Member Author

ywkim312 commented Feb 1, 2024

Can you remove the system.out print statements in GeoserverRestAPI?

removed

@ywkim312 ywkim312 merged commit 11cee61 into develop Feb 1, 2024
6 checks passed
@ywkim312 ywkim312 deleted the 259-investigate-to-see-if-geoserver-rest-api-need-to-have-the-same-method-when-uploading-data-to-geoserver branch February 1, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate to see if geoserver rest api need to have the same method when uploading data to geoserver
3 participants