add retrofit defintions #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longshuicy
requested review from
Rashmil-1999,
navarroc,
ywkim312 and
Vismayak
navarroc
reviewed
Feb 1, 2024
...dfr3-service/src/main/java/edu/illinois/ncsa/incore/service/dfr3/models/MappingEntryKey.java
Outdated
Show resolved
Hide resolved
navarroc
reviewed
Feb 1, 2024
...ervice/src/main/java/edu/illinois/ncsa/incore/service/dfr3/models/MappingEntryKeyConfig.java
Show resolved
Hide resolved
navarroc
reviewed
Feb 1, 2024
...dfr3-service/src/main/java/edu/illinois/ncsa/incore/service/dfr3/models/MappingEntryKey.java
Show resolved
Hide resolved
ylyangtw
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added Fragility Mapping Entry keys where we can utilize to properly define fragilities and retrofit.
To test this PR:
POST to /dfr3/api/mappings with below body as
application/json.Use the below json for test body
galveston_sw_plus_retrofit_mapping.json
galveston_flood_plus_retrofit_mapping.json
SLC_plus_retrofit.json
GET /dfr3/api/mappings and try GET /mappings/{ID posted from step 1)
DELETE /dfr3/api/mappings/{ID posted from step 1}