205 deploy approval app #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywkim312
requested changes
Jan 2, 2025
ywkim312
requested changes
Jan 2, 2025
| - name: KEYCLOAK_USERNAME | ||
| value: {{ .Values.approval.KEYCLOAK_USERNAME | quote }} | ||
| - name: KEYCLOAK_PASSWORD | ||
| {{- if .Values.approval.KEYCLOAK_PASSWORD }} |
There was a problem hiding this comment.
let not put the direct insert of KEYCLOAK password in here, instead just make it only to use the secret like you put below
There was a problem hiding this comment.
but I would need to overwrite it with production keycloak password on dev, hence I have this additional logic.
There was a problem hiding this comment.
dev and prod uses different secret so you can set it in there, instead of directly put
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to be reviewed.
Since currently I'm deploying on incore-dev connecting with production keycloak, I allowed the overrride (in the values file) to point to production keycloak url and password. But the default should be where it is default if no overrride.